Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding pt-br translation #87

Merged
merged 4 commits into from
Sep 28, 2018
Merged

adding pt-br translation #87

merged 4 commits into from
Sep 28, 2018

Conversation

Pompeu
Copy link
Contributor

@Pompeu Pompeu commented Sep 24, 2018

No description provided.

prev: "‹ Anterior"
next: "Próximo ›"
gap: "…"
current: "Esta na página"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Esta" should be "Está"

zero: "Sem resultados"
one: "Mostrando 1 %{item_name}"
other: "Mostrando %{count} %{item_name}"
multiple_pages: "Mostrando %{item_name} %{from}-%{to} de %{count} no total"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be de other way around:

"Mostrando %{from}-%{to} %{item_name} de %{count} no total"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Mostrando %{from}-%{to} %{item_name} de %{count} no total"

myabe ? Mostrando %{item_name} %{from}-%{to} no total de %{count}

@ddnexus
Copy link
Owner

ddnexus commented Sep 24, 2018

Thanks for this. Do you think it could be possible to get a single translation that could work for both pt-br and for pt-pt?

@Pompeu
Copy link
Contributor Author

Pompeu commented Sep 24, 2018

Thanks for this. Do you think it could be possible to get a single translation that could work for both pt-br and for pt-pt?

i dont know!
same libs use pt-br and only pt for translate, like momentjs, maybe we can use onlye pt ?
if u like i change for pt only.

@ddnexus
Copy link
Owner

ddnexus commented Sep 24, 2018

@Pompeu: According to @gamafranco something of what is in the pt-br would not sound right in pt-pt. My request was if you could find a common way to translate it, so it would work for pt-br and pt-pt. @gamafranco ?

@Pompeu
Copy link
Contributor Author

Pompeu commented Sep 27, 2018

@Pompeu: According to @gamafranco something of what is in the pt-br would not sound right in pt-pt. My request was if you could find a common way to translate it, so it would work for pt-br and pt-pt. @gamafranco ?

i dont know, i see all time in same libs, pt-br and pt-pt, i see this in subtitles of films too.

of: "de"
items:
show: "Mostrar"
items: "items por página"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

items: "items por página"
Should it be? 'itens por página'

of: "de"
items:
show: "Mostrar"
items: "items por página"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use other or items_per_page instead of items: twice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will fix all "items" to itens

@ddnexus
Copy link
Owner

ddnexus commented Sep 27, 2018

@Pompeu: yes, that is what I mean... however IIRC, in a private chat @gamafranco told me something about "Mostrar" that is not used in regular Portuguese. So what I was asking is translating the file in such a way that it would sound right for both Brazilian and Portuguese.

@gamafranco
Copy link
Contributor

The problem is not with "mostrar", it's with "mostrando"

@gamafranco
Copy link
Contributor

We use "a mostrar" instead of "mostrando"

@ddnexus
Copy link
Owner

ddnexus commented Sep 27, 2018

@Pompeu, @juuh42dias Would "a mostrar" work also for pt-br?

@Pompeu
Copy link
Contributor Author

Pompeu commented Sep 27, 2018

@Pompeu, @juuh42dias Would "a mostrar" work also for pt-br?
no make sense in pt-br use of "a mostar", why mostrando == showing == "a mostrar",
generally in Brazil we dont use "a mostrar" ( "a" is not a prefix here, because we use "ando" is same as "ing" in english.

@ddnexus
Copy link
Owner

ddnexus commented Sep 27, 2018

@Pompeu @juuh42dias I suggest to post a quick round of alternative translation that work for pt-br...
@gamafranco same for a few alternatives for pt-pt...
Then we may find a common translation OR we could add 2 different locales.

@ddnexus ddnexus changed the base branch from master to dev September 28, 2018 15:02
@ddnexus ddnexus merged commit 4ab3438 into ddnexus:dev Sep 28, 2018
@ddnexus
Copy link
Owner

ddnexus commented Sep 28, 2018

Added as pt-br; pt-pt will get another entry.

@ddnexus ddnexus added the merged label Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants